[Webkit-unassigned] [Bug 188680] New: REGRESSION(r234930): Don't embed a #if in an ASSERT

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=188680

            Bug ID: 188680
           Summary: REGRESSION(r234930): Don't embed a #if in an ASSERT
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ross.kirsling at sony.com

r234930 embeds a #if in an ASSERT, which is an error for MSVC:
> Source\WebCore\page/EventHandler.cpp(3707): error C2121: '#': invalid character: possibly the result of a macro expansion
> Source\WebCore\page/EventHandler.cpp(3699): error C2059: syntax error: 'if'
> Source\WebCore\page/EventHandler.cpp(3707): error C2143: syntax error: missing ';' before '{'

It is also a warning for Clang (-Wembedded-directive):
> warning: embedding a directive within macro arguments has undefined behavior

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180816/050cde7a/attachment.html>