[Webkit-unassigned] [Bug 188408] [GTK] Web Inspector: Checkboxes in Inspector elements panel are rendered incorrect

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 16 01:31:49 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=188408

--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Carlos Eduardo Ramalho from comment #5)
> (In reply to Michael Catanzaro from comment #3)
> > Hm, there should be a fallback style (used e.g. for WPE)
> 
> WPE uses a different Theme API (guarded by USE(NEW_THEME)), where drawing of
> widgets is done directly via GraphicsContext calls. Hence no need for a
> widget library. This code is in WebCore/platform/wpe/ThemeWPE.cpp

I don't think NEW_THEME imposes to use graphics context, it's the same with the other path, we get a graphics context too. The problem is that the GTK+ theme api renders in a cairo context that we get from the graphics context.

> I was thinking of migrating the GTK theme to this new model to enable
> threaded painting in WebKitGTK+ (see discussion in bug 186840) but it's a
> lot of work... Not sure if it's the best thing to do in the long-term.
> Currently Mac and WPE ports use NEW_THEME.
> 
> What do you think about this, Carlos Garcia?

I don't understand how using NEW_THEME would allow us to enable threaded painting. Could you elaborate?

> Not sure if this discussion should be placed in this bug.. If a follow-up
> discussion is worth I could open another bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180816/bb6577e7/attachment-0001.html>


More information about the webkit-unassigned mailing list