[Webkit-unassigned] [Bug 188464] Support drag-and-drop for input[type=color]

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 15 14:05:24 PDT 2018


Wenson Hsieh <wenson_hsieh at apple.com> changed:

           What    |Removed                     |Added
 Attachment #347173|review?                     |review+
              Flags|                            |

--- Comment #37 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 347173
  --> https://bugs.webkit.org/attachment.cgi?id=347173

View in context: https://bugs.webkit.org/attachment.cgi?id=347173&action=review

> Source/WebCore/page/DragController.cpp:917
> +    bool isColorControl = (is<HTMLInputElement>(state.source.get()) && downcast<HTMLInputElement>(*state.source.get()).isColorControl());

Nit - I don't think the extra ()'s around the RHS are needed. (The second .get() can also be removed).

> Source/WebCore/page/DragController.cpp:1177
> +        auto& input = downcast<HTMLInputElement>(*state.source.get());

Nit - The .get() is unnecessary here.

> Source/WebCore/page/mac/DragControllerMac.mm:148
> +        supportedTypes.append(String(UIColorPboardType));

Nit - The explicit call to String() shouldn't be needed here.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180815/f53e8ba6/attachment-0001.html>

More information about the webkit-unassigned mailing list