[Webkit-unassigned] [Bug 188597] [GTK] Segmentation fault when creating an instance of WebKitFindController without a WebKitWebView

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=188597

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[GTK] Segmentation fault    |[GTK] Segmentation fault
                   |when creating an instance   |when creating an instance
                   |of FindController           |of WebKitFindController
                   |                            |without a WebKitWebView

--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
The problem is you didn't pass a WebKitWebView property. You're not really intended to create WebKitFindController yourself, but rather to get it from a WebKitWebView using webkit_web_view_get_find_controller().

Anyway, of course we should assert or emit a critical or something instead of crashing. My first instinct would be g_return_val_if_fail(), but there's no place where that would be possible. I guess we could add a g_assert() in webkitFindControllerConstructed, but that's not really a friendly way to signal API misuse. Not sure what we should do here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180815/ba789f95/attachment.html>