[Webkit-unassigned] [Bug 188568] [GTK][WPE] Implement subprocess sandboxing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=188568

--- Comment #10 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 347158
  --> https://bugs.webkit.org/attachment.cgi?id=347158
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347158&action=review

> Source/WebCore/ChangeLog:20
> +2018-08-15  Patrick Griffis  <pgriffis at igalia.com>
> +
> +        [GTK][WPE] Implement subprocess sandboxing
> +        https://bugs.webkit.org/show_bug.cgi?id=188568
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        No new tests (OOPS!).
> +
> +        * PlatformGTK.cmake:
> +
> +2018-08-14  Patrick Griffis  <pgriffis at igalia.com>
> +
> +        [GTK][WPE] Implement subprocess sandboxing
> +        https://bugs.webkit.org/show_bug.cgi?id=188568
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * PlatformGTK.cmake:
> +

Watch your ChangeLog! You've got duplicate entries in the other ChangeLog, too.

> Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:348
> +    // NOTE: This is shared code (LGPLv2.1+)

I would be more clear about where you copied it from....

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180815/a05a62a5/attachment-0001.html>