[Webkit-unassigned] [Bug 188464] Support drag-and-drop for input[type=color]

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 14 10:25:51 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=188464

--- Comment #32 from Aditya Keerthi <akeerthi at apple.com> ---
(In reply to Daniel Bates from comment #26)
> Comment on attachment 346938 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=346938&action=review
>
> > Source/WebCore/page/DragController.cpp:353
> > +        if (input.isColorControl() && !input.isDisabledFormControl())
> 
> We should not allow dragging when the control is read-only.

According to the specification, only text controls can be marked read-only. I've changed the code back to use isDisabledFormControl().

https://www.w3.org/TR/html5/sec-forms.html#the-readonly-attribute

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180814/6e7dbda9/attachment.html>


More information about the webkit-unassigned mailing list