[Webkit-unassigned] [Bug 187741] [Datalist] Add button to TextFieldInputs with a datalist

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=187741

Tim Horton <thorton at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #347041|review?                     |review+
              Flags|                            |

--- Comment #23 from Tim Horton <thorton at apple.com> ---
Comment on attachment 347041
  --> https://bugs.webkit.org/attachment.cgi?id=347041
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347041&action=review

> Source/WebCore/html/shadow/DataListButtonElement.cpp:49
> +    : HTMLDivElement(divTag, document), m_owner(owner)

I think we usually always wrap these.

> Source/WebCore/rendering/RenderThemeMac.mm:2081
> +    } else {
> +        if (box.style().direction() == TextDirection::RTL)

Why not fold these into the outer if?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180813/93c6b67a/attachment.html>