[Webkit-unassigned] [Bug 188477] [macOS] Color wells should appear pressed when presenting a color picker

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=188477

Tim Horton <thorton at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #346926|review?                     |review+
              Flags|                            |

--- Comment #6 from Tim Horton <thorton at apple.com> ---
Comment on attachment 346926
  --> https://bugs.webkit.org/attachment.cgi?id=346926
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346926&action=review

> Source/WebKit/UIProcess/mac/WebColorPickerMac.mm:55
> + at protocol WKPopoverColorWellDelegate<NSObject>

You should check, but I think we usually put a space before brackets for protocol conformance

> Source/WebKit/UIProcess/mac/WebColorPickerMac.mm:277
> +        [[NSColorPanel sharedColorPanel] setDelegate:nil];

Why do you use dot notation for delegate on one line and bracket notation on the next? DOTS!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180811/012def08/attachment-0001.html>