[Webkit-unassigned] [Bug 168091] [macOS debug] LayoutTest inspector/worker/resources-in-worker.html is a flaky timeout

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Aug 11 10:35:34 PDT 2018


Devin Rousso <webkit at devinrousso.com> changed:

           What    |Removed                     |Added
 Attachment #346950|review?                     |review+
              Flags|                            |

--- Comment #10 from Devin Rousso <webkit at devinrousso.com> ---
Comment on attachment 346950
  --> https://bugs.webkit.org/attachment.cgi?id=346950
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=346950&action=review


> LayoutTests/ChangeLog:8
> +        * inspector/worker/resources-in-worker-expected.txt:

Missing ChangeLog entries:
 * inspector/dom-debugger/resources/dataXHR.json: Added.
 * inspector/dom-debugger/xhr-breakpoints.html:

> LayoutTests/inspector/worker/resources-in-worker.html:61
> +                if (workerIsReady && workerTargetIsSet)

Just as a thought, you could use two `WI.WrappedPromise` here and have the test finish using `Promise.all([...]).then(resolve, reject);` or even make it async and use await.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180811/d1511e3e/attachment.html>

More information about the webkit-unassigned mailing list