[Webkit-unassigned] [Bug 188464] Support drag-and-drop for input[type=color]
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 10 19:49:21 PDT 2018
https://bugs.webkit.org/show_bug.cgi?id=188464
--- Comment #25 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 346938
--> https://bugs.webkit.org/attachment.cgi?id=346938
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=346938&action=review
> Source/WebCore/ChangeLog:18
> + Implemented createDragImageForColor to display a particular color swatch once
Nit - these are good comments to put next to the relevant functions a bit further down.
> Source/WebCore/page/DragController.cpp:350
> + Node* n = node.deprecatedShadowAncestorNode();
For variable names, we usually prefer full words over single letters or abbreviations (https://webkit.org/code-style-guidelines/#names-full-words)
> Source/WebCore/platform/mac/PasteboardMac.mm:230
> + platformStrategies()->pasteboardStrategy()->setTypes(types, m_pasteboardName);
Nit - this could be made a tiny bit cleaner by using an initializer list to create the types vector.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180811/8ffde3c6/attachment.html>
More information about the webkit-unassigned
mailing list