[Webkit-unassigned] [Bug 164833] LayoutTest inspector/worker/debugger-pause.html is a flaky failure

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 10 17:33:27 PDT 2018


--- Comment #7 from Joseph Pecoraro <joepeck at webkit.org> ---
(In reply to Brian Burg from comment #6)
> Comment on attachment 346941 [details]
> [PATCH] Proposed Fix
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=346941&action=review
> r=me
> > LayoutTests/inspector/worker/debugger-pause.html:115
> > +    Promise.resolve().then(() => {
> It would be interesting to abstract away the Promise mechanism to turn the
> event loop. Say, turnEventLoop().then(... would make the comment disappear.
> Is this something we should be doing in more worker tests? Would it be less
> fragile for the worker to post back a "I'm initialized!" message then
> continue the test? I think we use this pattern in Inspector layout test
> runner between the inspector and inspected page.

This one isn't the worker, its the frontend setting up the worker. Which is a shame.

I like the idea of turnEventLoop(), but it still would probably need a comment explains why.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180811/42be094e/attachment.html>

More information about the webkit-unassigned mailing list