[Webkit-unassigned] [Bug 164833] LayoutTest inspector/worker/debugger-pause.html is a flaky failure

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 10 17:17:34 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=164833

Brian Burg <bburg at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bburg at apple.com
 Attachment #346941|review?                     |review+
              Flags|                            |

--- Comment #6 from Brian Burg <bburg at apple.com> ---
Comment on attachment 346941
  --> https://bugs.webkit.org/attachment.cgi?id=346941
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=346941&action=review

r=me

> LayoutTests/inspector/worker/debugger-pause.html:115
> +    Promise.resolve().then(() => {

It would be interesting to abstract away the Promise mechanism to turn the event loop. Say, turnEventLoop().then(... would make the comment disappear.

Is this something we should be doing in more worker tests? Would it be less fragile for the worker to post back a "I'm initialized!" message then continue the test? I think we use this pattern in Inspector layout test runner between the inspector and inspected page.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180811/21ee1e05/attachment.html>


More information about the webkit-unassigned mailing list