[Webkit-unassigned] [Bug 188477] [macOS] Color wells should appear pressed when presenting a color picker

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=188477

--- Comment #4 from Tim Horton <thorton at apple.com> ---
(In reply to Aditya Keerthi from comment #3)
> (In reply to Tim Horton from comment #2)
> > Comment on attachment 346921 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=346921&action=review
> > 
> > > Source/WebCore/platform/mac/ThemeMac.mm:714
> > > +    NSButtonCell *buttonCell = button(ColorWellPart, controlStates, IntSize(zoomedRect.size()), zoomFactor);
> > 
> > This button is kept statically, right? Who unsets highlighted?
> 
> Each time a button cell is created, setUpButtonCell is called. This in turn
> calls updateStates, which sets the correct highlighted value given the
> state. Both of those methods are in ThemeMac. Now that I think about it, it
> might make sense to move the statement that sets the highlight from
> paintColorWell, to updateStates.

Yes please.

Also fix the build.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180810/ccd0d22e/attachment.html>