[Webkit-unassigned] [Bug 188477] [macOS] Color wells should appear pressed when presenting a color picker

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=188477

Tim Horton <thorton at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #346921|review?                     |review+
              Flags|                            |

--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 346921
  --> https://bugs.webkit.org/attachment.cgi?id=346921
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346921&action=review

> Source/WebCore/platform/mac/ThemeMac.mm:714
> +    NSButtonCell *buttonCell = button(ColorWellPart, controlStates, IntSize(zoomedRect.size()), zoomFactor);

This button is kept statically, right? Who unsets highlighted?

> Source/WebKit/UIProcess/WebColorPicker.cpp:48
> +    m_client = 0;

nullptr?

> Source/WebKit/UIProcess/mac/WebColorPickerMac.mm:98
> +    if (m_colorPickerUI) {

Why doesn't this just call endPicker?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180810/8f681be8/attachment-0001.html>