[Webkit-unassigned] [Bug 188440] [WPE] Build failure on fedora when not adding -lrt as a cmake linker flag.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=188440

--- Comment #4 from Michael Catanzaro <mcatanzaro at igalia.com> ---
(In reply to Konstantin Tokarev from comment #3)
> I think that indiscriminate forcing of -lrt on all cmake-based packages in
> repository is not a good practice

We don't do that, it's added only for WebKit, and only to work around this build failure:

%cmake \
  -DPORT=WPE \
  -DCMAKE_BUILD_TYPE=Release \
  -DENABLE_MINIBROWSER=ON \
  -DCMAKE_EXE_LINKER_FLAGS="${CMAKE_EXE_LINKER_FLAGS} -lrt" \
  -DCMAKE_SHARED_LINKER_FLAGS="${CMAKE_SHARED_LINKER_FLAGS} -lrt" \
%ifarch s390 aarch64
  -DUSE_LD_GOLD=OFF \
%endif
%ifarch s390 s390x ppc %{power64}
  -DENABLE_JIT=OFF \
  -DUSE_SYSTEM_MALLOC=ON \
%endif
..
popd

These lines:

  -DCMAKE_EXE_LINKER_FLAGS="${CMAKE_EXE_LINKER_FLAGS} -lrt" \
  -DCMAKE_SHARED_LINKER_FLAGS="${CMAKE_SHARED_LINKER_FLAGS} -lrt" \

are needed to build WPE, but not GTK. That's weird. They should be removed once this issue is resolved.







Unrelated: Chris, these lines:

%ifarch s390 s390x ppc %{power64}
  -DENABLE_JIT=OFF \
  -DUSE_SYSTEM_MALLOC=ON \
%endif

should be possible to remove since https://trac.webkit.org/changeset/232918/webkit/trunk/Source/cmake, but the current WPE release 2.21.2 is older than that commit, so that will have to wait for the next release.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180809/f2694b53/attachment.html>