[Webkit-unassigned] [Bug 188391] [Curl] Surface additional NetworkLoadMetrics

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=188391

--- Comment #4 from Basuke Suzuki <Basuke.Suzuki at sony.com> ---
Comment on attachment 346738
  --> https://bugs.webkit.org/attachment.cgi?id=346738
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346738&action=review

> Source/WebCore/platform/network/curl/CurlContext.cpp:82
> +static const ASCIILiteral http20Protocol { "h2"_s };

constant should be named like kHttpProtocol10, kHttpProtocol11, kHttpProtocol2. Also version number of HTTP/2 is just 2, not 2.0. https://http2.github.io/faq/#is-it-http20-or-http2

>> Source/WebCore/platform/network/curl/CurlContext.cpp:761
>> +    errorCode = curl_easy_getinfo(m_handle, CURLINFO_REQUEST_SIZE, &requestHeaderSize);
> 
> Can you subtract out the requestBodySize to get requestHeaderSize closer to the actual value? You'd want to do some sanity checking to see if that makes sense.

Write. Request size includes entire size (header + body). I confirmed that by reading code for libcurl.

>> Source/WebCore/platform/network/curl/CurlContext.cpp:773
>> +    errorCode = curl_easy_getinfo(m_handle, CURLINFO_SIZE_DOWNLOAD_T, &responseBodySize);
> 
> Same here, does this include the Header Size or not? The curl docs did not seem clear to me.

This doesn't include the header size.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180809/8fa9ae2d/attachment.html>