[Webkit-unassigned] [Bug 188399] Web Inspector: Consider raising the 4gb process memory limit for WebInspector process

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=188399

Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bburg at apple.com

--- Comment #1 from Joseph Pecoraro <joepeck at webkit.org> ---
In WebKit the Web Inspector frontend page is just a WebPageProxy:

    void WebInspectorProxy::createFrontendPage()
    {
        if (m_inspectorPage)
            return;

        m_inspectorPage = platformCreateFrontendPage();
        ...
        trackInspectorPage(m_inspectorPage);
        ...
    }


However these inspector frontend pages are put into special WebProcessPools meant for only Inspector Pages:

    WebProcessPool& inspectorProcessPool(unsigned inspectionLevel)
    {
        // Having our own process pool removes us from the main process pool and
        // guarantees no process sharing for our user interface.
        WebProcessPool*& pool = (inspectionLevel == 1) ? s_mainInspectorProcessPool : s_nestedInspectorProcessPool;
        if (!pool) {
            auto configuration = API::ProcessPoolConfiguration::createWithLegacyOptions();
            pool = &WebProcessPool::create(configuration.get()).leakRef();
        }
        return *pool;
    }

This makes me think that if we can set a bit on the WebProcessProxy / WebProcess that says "You're a Debugger Process".

Then when the first WebPage is created in the process pool it could propagate the property to the pressure handler:

    MemoryPressureHandler::singleton()->setDebuggerProcess();

This could then raise / affect the limit.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180808/d6a4da64/attachment-0001.html>