[Webkit-unassigned] [Bug 188368] Add CEReactions=NotNeeded on all the relevant IDL files
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 7 22:15:03 PDT 2018
https://bugs.webkit.org/show_bug.cgi?id=188368
--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 346695
--> https://bugs.webkit.org/attachment.cgi?id=346695
Patch (extracting changes and rebasing attachment 345839)
View in context: https://bugs.webkit.org/attachment.cgi?id=346695&action=review
> Source/WebCore/html/HTMLElement.idl:65
> [Conditional=IOS_AUTOCORRECT_AND_AUTOCAPITALIZE] attribute boolean autocorrect;
We need CEReactions here too for autocorrect content attribute.
> Source/WebCore/html/HTMLElement.idl:66
> - [Conditional=IOS_AUTOCORRECT_AND_AUTOCAPITALIZE] attribute [TreatNullAs=EmptyString] DOMString autocapitalize;
> + [CEReactions, Conditional=IOS_AUTOCORRECT_AND_AUTOCAPITALIZE] attribute [TreatNullAs=EmptyString] DOMString autocapitalize;
We need a test for this. We should probably make this change in a separate patch.
> Source/WebCore/html/HTMLInputElement.idl:91
> [Reflect] attribute boolean incremental;
We should probably add CEReactions=NotNeeded on apparently non-standard IDL attribute.
> Source/WebCore/html/HTMLLinkElement.idl:44
> [Reflect] attribute DOMString nonce;
nonce content attribute should have CEReactions=NotNeeded even though the spec doesn't say that:
https://html.spec.whatwg.org/multipage/urls-and-fetching.html#nonce-attributes
Filed https://github.com/whatwg/html/issues/3887
> Source/WebCore/html/HTMLMediaElement.idl:96
> attribute boolean webkitPreservesPitch;
Non-standard mediaGroup below should have CEReactions=NotNeeded as well.
> Source/WebCore/html/HTMLPreElement.idl:27
> [Reflect] attribute boolean wrap;
Need CEReactions=NotNeeded on this extension.
> Source/WebCore/html/HTMLScriptElement.idl:31
> [Reflect] attribute DOMString nonce;
We should add CEReactions=NotNeeded here as well.
> Source/WebCore/html/HTMLStyleElement.idl:27
> readonly attribute StyleSheet sheet;
Ditto about adding CEReactions=NotNeeded to the nonce IDL attribute below.
> Source/WebCore/html/HTMLTextAreaElement.idl:39
> + [CEReactions=NotNeeded] attribute [TreatNullAs=EmptyString] DOMString value;
This is probably a spec bug: https://github.com/whatwg/html/issues/3889
textarea.value never mutates DOM.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180808/579bbb60/attachment.html>
More information about the webkit-unassigned
mailing list