[Webkit-unassigned] [Bug 188391] [Curl] Surface additional NetworkLoadMetrics

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=188391

Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #346738|review?                     |review+
              Flags|                            |

--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 346738
  --> https://bugs.webkit.org/attachment.cgi?id=346738
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346738&action=review

Nice! r=me

You may be able to enable a few of the Inspector LayoutTests. Namely:
LayoutTests/http/tests/inspector/network/resource-sizes-network.html

> Source/WebCore/platform/network/curl/CurlContext.cpp:739
> +    long protocol;

This appears to be unused and can be removed.

> Source/WebCore/platform/network/curl/CurlContext.cpp:761
> +    errorCode = curl_easy_getinfo(m_handle, CURLINFO_REQUEST_SIZE, &requestHeaderSize);

Can you subtract out the requestBodySize to get requestHeaderSize closer to the actual value? You'd want to do some sanity checking to see if that makes sense.

> Source/WebCore/platform/network/curl/CurlContext.cpp:773
> +    errorCode = curl_easy_getinfo(m_handle, CURLINFO_SIZE_DOWNLOAD_T, &responseBodySize);

Same here, does this include the Header Size or not? The curl docs did not seem clear to me.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180807/749dc06f/attachment-0001.html>