[Webkit-unassigned] [Bug 188358] New: WKURLSchemeHandler crashes when sent errors
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 6 14:14:08 PDT 2018
https://bugs.webkit.org/show_bug.cgi?id=188358
Bug ID: 188358
Summary: WKURLSchemeHandler crashes when sent errors
Product: WebKit
Version: Safari 11
Hardware: iPhone / iPad
OS: iOS 11
Status: NEW
Severity: Normal
Priority: P2
Component: New Bugs
Assignee: webkit-unassigned at lists.webkit.org
Reporter: robnapier at gmail.com
Created attachment 346655
--> https://bugs.webkit.org/attachment.cgi?id=346655&action=review
Demonstration Swift playground
Calling urlSchemeTask.didFailWithError() prior to sending data crashes with the following stack:
error: Execution was interrupted, reason: EXC_BAD_INSTRUCTION (code=EXC_I386_INVOP, subcode=0x0).
The process has been left at the point where it was interrupted, use "thread return -x" to return to the state before expression evaluation.
* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_INSTRUCTION (code=EXC_I386_INVOP, subcode=0x0)
* frame #0: 0x00000001223e5431 libswiftCore.dylib`function signature specialization <Arg[2] = Dead, Arg[3] = Dead> of Swift._fatalErrorMessage(_: Swift.StaticString, _: Swift.StaticString, file: Swift.StaticString, line: Swift.UInt, flags: Swift.UInt32) -> Swift.Never + 113
frame #1: 0x000000012221ad63 libswiftCore.dylib`Swift._fatalErrorMessage(_: Swift.StaticString, _: Swift.StaticString, file: Swift.StaticString, line: Swift.UInt, flags: Swift.UInt32) -> Swift.Never + 19
frame #2: 0x000000012679acfe $__lldb_expr18`main at Untitled Page.xcplaygroundpage:49
frame #3: 0x000000010c89a600 MyPlayground`linkResources + 304
frame #4: 0x000000010e03b76c CoreFoundation`__CFRUNLOOP_IS_CALLING_OUT_TO_A_BLOCK__ + 12
frame #5: 0x000000010e03af20 CoreFoundation`__CFRunLoopDoBlocks + 336
frame #6: 0x000000010e035784 CoreFoundation`__CFRunLoopRun + 1284
frame #7: 0x000000010e034f41 CoreFoundation`CFRunLoopRunSpecific + 625
frame #8: 0x000000011560e1b5 GraphicsServices`GSEventRunModal + 62
frame #9: 0x0000000111d23df4 UIKitCore`UIApplicationMain + 140
frame #10: 0x000000010c89a6cd MyPlayground`main + 205
frame #11: 0x000000010fa4b9ed libdyld.dylib`start + 1
Crash appears to be due to WebURLSchemeTask::didComplete, specifically this line (https://github.com/WebKit/webkit/blob/master/Source/WebKit/UIProcess/WebURLSchemeTask.cpp#L136):
m_syncCompletionHandler(m_syncResponse, error, IPC::DataReference { (const uint8_t*)m_syncData->data(), m_syncData->size() });
If didReceiveData has not been called yet, m_syncData will be nullptr, and crash.
didComplete explicitly permits no response to have been sent, if there is an error (note that the docs for Cocoa's didReceiveResponse are misleading about this; even if a response is sent, it doesn't address the issue, however).
if (!m_responseSent && error.isNull())
return ExceptionType::NoResponseSent;
This is also rdar://42974387
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180806/da30efe3/attachment-0001.html>
More information about the webkit-unassigned
mailing list