[Webkit-unassigned] [Bug 160484] iOS doesn't support indeterminate checkboxes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=160484

Wenson Hsieh <wenson_hsieh at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #346631|review?                     |
              Flags|                            |

--- Comment #8 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 346631
  --> https://bugs.webkit.org/attachment.cgi?id=346631
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346631&action=review

Looks good! Just a couple of minor comments...

> Source/WebCore/rendering/RenderThemeIOS.mm:374
> +static void drawJoinedLines(CGContextRef context, Vector<CGPoint> points, CGLineCap lineCap, float lineWidth, Color strokeColor)

This should probably be a const Vector<CGPoint>& (or Vector<CGPoint>&& combined with WTFMove at the call site).

> LayoutTests/fast/forms/ios/render-indeterminate-checkbox-expected-mismatch.html:8
> +function runTest()

Nit - it would be simpler to just have `document.querySelector("input").indeterminate = true;` in the script tag without wrapping it in runTest() and waiting until the load event, but this is okay too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180806/0477dad3/attachment.html>