[Webkit-unassigned] [Bug 188337] New: [libwebrtc] SafeSetError() in peerconnection.cc contains use-after-move of webrtc::RTCError variable

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=188337

            Bug ID: 188337
           Summary: [libwebrtc] SafeSetError() in peerconnection.cc
                    contains use-after-move of webrtc::RTCError variable
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Keywords: InRadar
          Severity: Normal
          Priority: P2
         Component: WebRTC
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ddkilzer at webkit.org
                CC: eric.carlson at apple.com, youennf at gmail.com

SafeSetError() in peerconnection.cc contains use-after-move of webrtc::RTCError variable:

bool SafeSetError(webrtc::RTCError error, webrtc::RTCError* error_out) {
  if (error_out) {
    *error_out = std::move(error);
  }
  return error.ok();
}

Seems like error.ok() should be read before the std::move(), or *error_out.ok() or error_out->ok() should be used instead.

<rdar://problem/42882908>

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180806/cfef1cbe/attachment-0001.html>