[Webkit-unassigned] [Bug 188299] Web process never leaves memory pressured state if caused by per-process limit

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 3 10:34:24 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=188299

--- Comment #5 from Antti Koivisto <koivisto at iki.fi> ---
> > Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm:96
> > +                return MemoryPressureHandler::singleton().isUnderMemoryPressure();
> 
> Is this line only about simulated memory pressure? If so, would be nice to
> rename that function since it's really confusing that the input to
> setUnderMemoryPressure() uses isUnderMemoryPressure().

No, that line is about making DISPATCH_MEMORYPRESSURE_PROC_LIMIT_* notifications to have no effect to the memory pressure state. When we get those we just stay in the current state.

> I'm still not sure how you get out of memory pressure with this code, since
> isUnderVMMemoryPressure doesn't consult
> DISPATCH_MEMORYPRESSURE_PROC_LIMIT_CRITICAL.

Only DISPATCH_MEMORYPRESSURE_CRITICAL puts us into the pressured state, we get out when we receive DISPATCH_MEMORYPRESSURE_NORMAL or DISPATCH_MEMORYPRESSURE_WARN.

> These NSLogs should be WTFLogAlways, so they show in iOS syslog. Are they
> even useful with all the release logging we have? Should they be release
> logs?

I suppose release logging changes in pressure state might be useful.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180803/1dd19a57/attachment-0001.html>


More information about the webkit-unassigned mailing list