[Webkit-unassigned] [Bug 181855] [EME][GStreamer] Move the decryptor from AppendPipeline to PlaybackPipeline.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 27 02:59:29 PDT 2018


--- Comment #11 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 338892
  --> https://bugs.webkit.org/attachment.cgi?id=338892

View in context: https://bugs.webkit.org/attachment.cgi?id=338892&action=review

> Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:958
> +        gst_element_send_event(m_playbackPipeline->pipeline(), gst_event_new_custom(GST_EVENT_CUSTOM_DOWNSTREAM_OOB, gst_structure_copy(structure.get())));

You don't need to copy the structure since we are given a rvalue reference. Just .release() instead of .get() and avoid the gst_structure_copy.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180427/821a045d/attachment.html>

More information about the webkit-unassigned mailing list