[Webkit-unassigned] [Bug 184823] REGRESSION(r230812): [WPE][GTK] WebKitWebViewSessionState.cpp throws away encoded BackForwardList identifier

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=184823

--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Michael Catanzaro from comment #4)
> Comment on attachment 338868 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=338868&action=review
> 
> > Source/WebKit/UIProcess/API/glib/WebKitWebViewSessionState.cpp:394
> > +    GRefPtr<GVariant> variant;
> > +    for (unsigned i = 0; sessionStateTypeStringVersions[i]; ++i) {
> > +        sessionStateTypeString = sessionStateTypeStringVersions[i];
> > +        variant = g_variant_new_from_bytes(G_VARIANT_TYPE(sessionStateTypeString), data, FALSE);
> > +        if (g_variant_is_normal_form(variant.get()))
> > +            break;
> > +        variant = nullptr;
> > +    }
> 
> You've tested this to ensure it doesn't emit a bunch of warnings or
> criticals when the type doesn't match?

Yes, of course I tested it. My ephy history was successfully encoded with version 1 (2 is tried first) and decoded with 2.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180427/02f29d28/attachment.html>