[Webkit-unassigned] [Bug 185054] New: REGRESSION: run-webkit-tests runs tests in skipped directories and subdirectories of directory given on command line

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 26 15:02:34 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=185054

            Bug ID: 185054
           Summary: REGRESSION: run-webkit-tests runs tests in skipped
                    directories and subdirectories of directory given on
                    command line
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: dbates at webkit.org
                CC: jbedard at apple.com, lforschler at apple.com,
                    rniwa at webkit.org

According the description of --skipped in run-webkit-tests --help, when --skipped is omitted run-webkit-tests should "skip tests [marked SKIP explicitly or implicitly because they are in a directory marked SKIP (*)] unless explicitly listed on the command line". 

Steps to reproduce:

The following steps assume you are running the tests on a Mac and that http/tests/quicklook is skipped on Mac, which it is at the time of writing it is by <https://trac.webkit.org/browser/trunk/LayoutTests/TestExpectations?rev=231065#L110>. (http/tests/quicklook is skipped on all non-iOS ports).

1. Run `Tools/Scripts/run-webkit-tests http/tests/quicklook`.

Then run-webkit-tests will run the tests in http/tests/quicklook. But it should not have because --skipped was not given and http/test/quicklook is skipped on Mac.

Similarly, running `Tools/Scripts/run-webkit-tests http/tests` will run tests in http/tests/quicklook. But it should not have by the same aforementioned reason.

(*) This criterion is implied by the second paragraph in the ChangeLog that added --skipped: <https://trac.webkit.org/changeset/120348/>.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180426/88342719/attachment.html>


More information about the webkit-unassigned mailing list