[Webkit-unassigned] [Bug 181855] [EME][GStreamer] Move the decryptor from AppendPipeline to PlaybackPipeline.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=181855

--- Comment #6 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 333490
  --> https://bugs.webkit.org/attachment.cgi?id=333490
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333490&action=review

> Source/WebCore/platform/graphics/gstreamer/mse/PlaybackPipeline.cpp:186
> +        GST_DEBUG_OBJECT(webKitMediaSrc, "It's an encrypted content, the parser plugins will be auto plugged by the decodebin");

Please, just use GST_DEBUG because otherwise you're saying that the source of that message is that object and it is not true. Besides, this message is unclear to me. Do you mean the parser or the decryptor? Plugins plural? My guess is that you just mean decryptor elements.

> Source/WebCore/platform/graphics/gstreamer/mse/PlaybackPipeline.cpp:348
> +    for (Stream* stream : priv->streams) {
> +        if (stream->appsrc)
> +            appsrcs.append(GST_APP_SRC(stream->appsrc));
> +    }

You don't need the { } here.

> Source/WebCore/platform/graphics/gstreamer/mse/PlaybackPipeline.cpp:354
> +    WebKitMediaSrcPrivate* priv = m_webKitMediaSrc->priv;
> +    Vector<GstAppSrc*> appsrcs;
> +
> +    GST_OBJECT_LOCK(m_webKitMediaSrc.get());
> +    for (Stream* stream : priv->streams) {
> +        if (stream->appsrc)
> +            appsrcs.append(GST_APP_SRC(stream->appsrc));
> +    }
> +    GST_OBJECT_UNLOCK(m_webKitMediaSrc.get());
> +
> +    for (GstAppSrc* appsrc : appsrcs) {
> +        GST_TRACE("dispatching key to playback pipeline %p", this);
> +        gst_element_send_event((GstElement*)appsrc, gst_event_new_custom(GST_EVENT_CUSTOM_DOWNSTREAM_OOB, gst_structure_copy(structure.get())));
> +    }

What's the problem of just sending the event to the pipeline itself?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180426/2e541238/attachment.html>