[Webkit-unassigned] [Bug 184913] [GTK] Implement MouseEvent.buttons

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=184913

Ms2ger <Ms2ger at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Ms2ger at igalia.com

--- Comment #2 from Ms2ger <Ms2ger at igalia.com> ---
Comment on attachment 338644
  --> https://bugs.webkit.org/attachment.cgi?id=338644
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338644&action=review

> Source/WebKit/Shared/gtk/WebEventFactory.cpp:154
> +        unsigned modifier = 1 << (8 + event->button.button - 1);

I've seen this calculation about five times in this patch; worth writing a small helper function?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180425/7936ccc0/attachment.html>