[Webkit-unassigned] [Bug 184958] Extend create-analysis-task API to be able to create with confirming test group.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=184958

--- Comment #2 from dewei_zhu at apple.com ---
Comment on attachment 338713
  --> https://bugs.webkit.org/attachment.cgi?id=338713
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338713&action=review

> Websites/perf.webkit.org/public/include/json-header.php:201
> +function insert_commit_sets_and_construct_configuration_list($db, $commit_sets)

How do you like the idea that creating a new file to contain all helper functions those are not related to 'json-header.php'? For example, it seems like 'find_triggerable_for_task' (line169) should not be in 'json-header.php'.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180425/7581cea2/attachment-0001.html>