[Webkit-unassigned] [Bug 184919] AX: soft link libAccessibility.dylb

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=184919

--- Comment #11 from Nan Wang <n_wang at apple.com> ---
Comment on attachment 338706
  --> https://bugs.webkit.org/attachment.cgi?id=338706
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338706&action=review

>> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:706
>> +        CFNotificationCenterAddObserver(CFNotificationCenterGetDarwinNotifyCenter(), (__bridge const void *)(self), accessibilityEventsEnabledChangedCallback, kAXSWebAccessibilityEventsEnabledNotification, 0, CFNotificationSuspensionBehaviorDeliverImmediately);
> 
> Not new to this patch, but why is it OK to add this observer and never remove it?

Good catch, there is CFNotificationCenterRemoveObserver in dealloc but it's guarded in PLATFORM(IOS).
I will move that into #if ENABLE(ACCESSIBILITY_EVENTS) since that's the only place with CFNotification

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180425/d7d56979/attachment-0001.html>