[Webkit-unassigned] [Bug 184758] Runtime feature flag for Server-Timing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=184758

--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 338263
  --> https://bugs.webkit.org/attachment.cgi?id=338263
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338263&action=review

> Source/WTF/wtf/FeatureDefines.h:687
> +#endif

These are compile flags. I am not sure we need this one actually.
Instead, I would go just with a runtime flag.

> Source/WebCore/page/RuntimeEnabledFeatures.h:254
> +    bool serverTimingEnabled() const { return m_isServerTimingEnabled; }

This is the runtime flag there.
To allow STP users to enable it as an experimental feature, you would need to add it to WebPreferences.yaml.
You will also need to activate it in WebKitTestRunner and DumpRenderTree by default. To ServiceWorker processes as well probably.
See for instance restrictedHTTPResponseAccess above as an example.

To validate that it is working, you could for instance add:
- some IDL behind the runtime flag: PerformanceServerTiming.idl/.h/.cpp and the change to PerformanceResourceTiming.idl
- a test verifying that the property is there on PerformanceResourceTiming.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180423/e8c668a5/attachment.html>