[Webkit-unassigned] [Bug 184650] [GStreamer] Start implementing Audio/VideoTrackPrivateGSTreamer::kind method

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=184650

--- Comment #7 from Thibault Saunier <tsaunier at gnome.org> ---
(In reply to Philippe Normand from comment #3)
> Comment on attachment 338000 [details]
> [GStreamer] Start implementing Audio/VideoTrackPrivateGSTreamer::kind method
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=338000&action=review
> 
> > Source/WebCore/ChangeLog:12
> > +        No new tests are added as we already have a few ones that are currently disabled in
> > +        the mediastream testsuite. This patch is part of the work to enable them.
> 
> Maybe the media/ test suite has a test for this though?

Enhanced the ChangeLog to explain why I didn't add tests.

> > Source/WebCore/platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp:57
> > +    if (m_stream.get() && gst_stream_get_stream_flags (m_stream.get()) & GST_STREAM_FLAG_SELECT)
> 
> No space before ( please :)

Fixed.

> 
> > Source/WebCore/platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp:57
> > +    if (m_stream.get() && gst_stream_get_stream_flags (m_stream.get()) & GST_STREAM_FLAG_SELECT)
> 
> Ditto

Fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180423/03aaeb82/attachment.html>