[Webkit-unassigned] [Bug 184823] REGRESSION(r230812): [WPE][GTK] WebKitWebViewSessionState.cpp throws away encoded BackForwardList identifier

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 21 00:01:38 PDT 2018


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
                 CC|                            |cgarcia at igalia.com

--- Comment #1 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Michael Catanzaro from comment #0)
> Since r230812, decodeBackForwardListItemState in
> WebKitWebViewSessionState.cpp no longer reads the encoded BackForwardList
> identifier.


> First, we should figure out if this is bad. Does the BackForwardList still
> get deserialized properly? It's not clear to me.

Nah, it's not bad because WebBackForwardList::restoreFromState() assigns a new identifier to the item without checking the saved one. This was done before as well, so I think we were saving the identifier in the state for nothing. Brady, correct me if I'm wrong.

> If it's not bad, we should at least stop encoding the identifier, since it's
> silly to encode something that's never decoded. To avoid the need to change
> the serialization format, we could just start encoding 0, for example, with
> a comment to indicate that it should be dropped if we ever need to bump the
> serialization format.

It should be easy to handle this change, I think.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180421/6b6b3594/attachment.html>

More information about the webkit-unassigned mailing list