[Webkit-unassigned] [Bug 184766] Tool scripts should not use PrivilegedAPI from 'public/v3/privileged-api.js'.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 20 16:57:06 PDT 2018


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #338444|review?                     |review+
              Flags|                            |

--- Comment #5 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 338444
  --> https://bugs.webkit.org/attachment.cgi?id=338444

View in context: https://bugs.webkit.org/attachment.cgi?id=338444&action=review

> Websites/perf.webkit.org/tools/js/privileged-api.js:8
> +        for (let key in data)

Use const.

> Websites/perf.webkit.org/unit-tests/resources/mock-remote-api.js:63
> +    inject: function (urlPrefix, useNodePrivilegedAPI)

We should make inject either make a dictionary or the second argument should be
a string specifying the type of PrivilegedAPI we use; e.g. 'browser' (default) / 'node'.

> Websites/perf.webkit.org/unit-tests/resources/mock-remote-api.js:67
> +        const hookPrivilegedAPI = useNodePrivilegedAPI ? NodePrivilegedAPI: BrowserPrivilegedAPI;

Use call this PrivilegedAPI.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180420/611f2237/attachment.html>

More information about the webkit-unassigned mailing list