[Webkit-unassigned] [Bug 184419] Write a script that detects chart changes by using v3 API.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 20 15:32:21 PDT 2018


--- Comment #3 from dewei_zhu at apple.com ---
Comment on attachment 337503
  --> https://bugs.webkit.org/attachment.cgi?id=337503

View in context: https://bugs.webkit.org/attachment.cgi?id=337503&action=review

>> Websites/perf.webkit.org/tools/run-analysis.js:137
>> +        const filteredRanges = ranges.filter((range) => range.endPoint.time >= startTime && !range.overlappingAnalysisTasks.length)
> What's the point of range.endPoint.time >= startTime?

I translated the logic from detect-change-script. I think what this is trying to do is the make sure at least part of the range should inside the time range specified by configurations.

>> Websites/perf.webkit.org/tools/run-analysis.js:141
>> +        for (range of filteredRanges) {
> We're finding the last range??
> Why don't we find the range with the biggest change instead?
> I'm pretty sure that's what I had in v2.

Actually, we don't. But that sounds a better strategy.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180420/e7f1434c/attachment.html>

More information about the webkit-unassigned mailing list