[Webkit-unassigned] [Bug 184582] Add SetCallee as DFG-Operation
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 20 15:00:09 PDT 2018
https://bugs.webkit.org/show_bug.cgi?id=184582
--- Comment #17 from Saam Barati <sbarati at apple.com> ---
(In reply to Saam Barati from comment #16)
> Comment on attachment 338440 [details]
> Patch
>
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=338440&action=review
>
> > Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1402
> > + setDirect(stackEntry->remapOperand(VirtualRegister(CallFrameSlot::callee)), callTargetNode, NormalSet);
>
> Why setDirect here? Why not also emit that for the machine frame case
> instead of adding a SetCallee node?
> Or is the SetCallee node needed for some reason?
LGTM too in general. Just this one question.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180420/9167d277/attachment.html>
More information about the webkit-unassigned
mailing list