[Webkit-unassigned] [Bug 180528] Update HSL/HSLA parsing to match CSS Color 4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 20 14:16:51 PDT 2018


--- Comment #40 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 338448
  --> https://bugs.webkit.org/attachment.cgi?id=338448

View in context: https://bugs.webkit.org/attachment.cgi?id=338448&action=review

> Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:536
> +    RefPtr<CSSPrimitiveValue> hslValue = consumeAngle(args, cssParserMode, UnitlessQuirk::Forbid);


> Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:537
> +    double angleValue;

Bonus points if the name indicates if it's degrees or radians.

> Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:546
> +    // The hue needs to be in the range [0.0, 6.0)

This needs a comment to say where the 6 comes from. I assume this feeds into the calcHue logic. Should we convert to the 6-based values here, or keep it as an angle at this point?

> Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:570
> +            RefPtr<CSSPrimitiveValue> alphaPercent = consumePercent(args, ValueRangeAll);


You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180420/c453c39b/attachment.html>

More information about the webkit-unassigned mailing list