[Webkit-unassigned] [Bug 183060] [Curl][WinCairo] WinCairo should use a Public Suffix List to prevent cookies from being set for TLDs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=183060

Christopher Reid <chris.reid at sony.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #338381|                            |review?
              Flags|                            |

--- Comment #12 from Christopher Reid <chris.reid at sony.com> ---
Created attachment 338381

  --> https://bugs.webkit.org/attachment.cgi?id=338381&action=review

Updated patch

I ended up keeping a return of UCharBuffer instead of an LCharBuffer as there was a case where hostnames over 2048 characters won't get encoded to punycode.

I also tried to modernize chromium's lookup code a bit. The dafsa data is now using a static NeverDestroyed vector instead of a raw array.

Also this is a bit out of scope from these changes but one thing I noticed is that URL.cpp is still using the deprecated uidna_IDNToASCII for encoding hostnames. Is there a reason it wasn't updated to use IDN2008 yet? I tried it out in trunk and setting window.location.host or window.location.href to a hostname containing ß can resolve to different domains.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180420/53b291fa/attachment.html>