[Webkit-unassigned] [Bug 182225] Support calc() in webkit-gradient and cross-fade

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=182225

--- Comment #11 from Chris Nardi <cnardi at chromium.org> ---
(In reply to Simon Fraser (smfr) from comment #9)
> Comment on attachment 332721 [details]
> Change order of summary in changelogs
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=332721&action=review
> 
> > Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:869
> > +        if (RefPtr<CSSPrimitiveValue> percentValue = consumePercent(args, ValueRangeAll))
> 
> This could be if (auto percentValue = consumePercent(args, ValueRangeAll))
> 
> > Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:1231
> > +    if (RefPtr<CSSPrimitiveValue> percentValue = consumePercent(args, ValueRangeAll))
> > +        percentage = CSSValuePool::singleton().createValue(clampTo<double>(percentValue->doubleValue() / 100.0, 0, 1), CSSPrimitiveValue::UnitType::CSS_NUMBER);
> > +    else if (RefPtr<CSSPrimitiveValue> numberValue = consumeNumber(args, ValueRangeAll))
> 
> You could use auto here too.

I changed both situations to use auto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180419/d2470877/attachment.html>