[Webkit-unassigned] [Bug 182225] Support calc() in webkit-gradient and cross-fade

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=182225

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #332721|review?                     |review+
              Flags|                            |

--- Comment #9 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 332721
  --> https://bugs.webkit.org/attachment.cgi?id=332721
Change order of summary in changelogs

View in context: https://bugs.webkit.org/attachment.cgi?id=332721&action=review

> Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:869
> +        if (RefPtr<CSSPrimitiveValue> percentValue = consumePercent(args, ValueRangeAll))

This could be if (auto percentValue = consumePercent(args, ValueRangeAll))

> Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:1231
> +    if (RefPtr<CSSPrimitiveValue> percentValue = consumePercent(args, ValueRangeAll))
> +        percentage = CSSValuePool::singleton().createValue(clampTo<double>(percentValue->doubleValue() / 100.0, 0, 1), CSSPrimitiveValue::UnitType::CSS_NUMBER);
> +    else if (RefPtr<CSSPrimitiveValue> numberValue = consumeNumber(args, ValueRangeAll))

You could use auto here too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180419/8a28e4df/attachment.html>