[Webkit-unassigned] [Bug 184742] AX: [macOS] WebKit hangs when triggering an alert from an AOM increment event

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 18 12:58:05 PDT 2018


--- Comment #3 from Nan Wang <n_wang at apple.com> ---
(In reply to chris fleizach from comment #2)
> Comment on attachment 338238 [details]
> patch
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=338238&action=review
> > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3593
> > +    else if ([action isEqualToString:@"AXSyncDecrementAction"])
> Should we remove the sync versions and fix the other tests? The sync
> versions aren’t that real anymore. What do you think

I tried to do that but a lot of the tests are doing increment/decrement multiple times and then check the value. That would require us to put tons of setTimeout in the tests and make them less readable.

Another concern is that this is only Mac but some tests are for all platforms so it's not reasonable to make them wait.

I think the core is not changed just the timing might be affected on macOS, so maybe keeping the sync version is not a bad idea?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180418/2f4e0ca3/attachment.html>

More information about the webkit-unassigned mailing list