[Webkit-unassigned] [Bug 184743] New: Remove the style checker rule for using release assert with security implication

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 18 11:23:59 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=184743

            Bug ID: 184743
           Summary: Remove the style checker rule for using release assert
                    with security implication
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: rniwa at webkit.org
                CC: lforschler at apple.com

https://trac.webkit.org/changeset/223421/webkit made it so that style check emits an error
whenever ASSERT_WITH_SECURITY_IMPLICATION is used instead of RELEASE_ASSERT_WITH_SECURITY_IMPLICATION.

I don't think we should have this style rule since using ASSERT_WITH_SECURITY_IMPLICATION
is a valid thing to do when there is a significant perf cost.

We've already had a perf regression from people mindlessly fixing this style error.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180418/48534837/attachment.html>


More information about the webkit-unassigned mailing list