[Webkit-unassigned] [Bug 184619] AX: AOM: respect the accessibility setting for dispatching the accessible events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=184619

--- Comment #31 from Ryosuke Niwa <rniwa at webkit.org> ---
(In reply to Nan Wang from comment #30)
> Comment on attachment 338165 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=338165&action=review
> 
> >> Source/WebCore/testing/Internals.cpp:270
> >> +void _AXSSetWebAccessibilityEventsEnabled(Boolean);
> > 
> > Does this feature enable it for this web content process, or is it system wide?
> > We can't mutate a global system state because we run tests concurrency.
> > 
> > Also, this should be done via internals.settings instead of any.
> 
> This is system wide. 
> If we do this via internals.settings instead, we are not going to test the
> CFNotification right?

But we can't mutate the system wide settings like this. It's okay if CFNotification path is not tested in layout tests. You should write an API test which manually dispatches a notification (again, without mutating the system wide setting).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180418/3eb3d316/attachment.html>