[Webkit-unassigned] [Bug 184619] AX: AOM: respect the accessibility setting for dispatching the accessible events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=184619

--- Comment #29 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 338165
  --> https://bugs.webkit.org/attachment.cgi?id=338165
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338165&action=review

> Source/WTF/wtf/Platform.h:1333
> +#define HAVE_ACCESSIBILITY_EVENTS 1

I think we should have ENABLE flag instead.

> Source/WebCore/page/Settings.yaml:735
> +  initial: true

This should be conditional to the build flag. It's weird to have an on-by-default flag which doesn't do anything loser OS

> Source/WebCore/testing/Internals.cpp:270
> +void _AXSSetWebAccessibilityEventsEnabled(Boolean);

Does this feature enable it for this web content process, or is it system wide?
We can't mutate a global system state because we run tests concurrency.

Also, this should be done via internals.settings instead of any.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180418/083dc9ed/attachment.html>