[Webkit-unassigned] [Bug 184494] Make WebDriverW3CWebServer inherit from WebPlatformTestServer

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 17 15:29:11 PDT 2018


--- Comment #4 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 337695
  --> https://bugs.webkit.org/attachment.cgi?id=337695

View in context: https://bugs.webkit.org/attachment.cgi?id=337695&action=review

> Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:42
> +        self._mappings = []

I wonder whether we could not unify a bit more W3C and WPT config.json files.
The first has an ssl config that might be needed to WebDriver at some point.
The other has doc_root but maybe it no longer needs it?

I guess the only difference that might need to remain would be ports if we wanted to have both W3C and WebDriver in parallel.
Maybe we do not even need different port values?

> Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:45
> +        doc_root = os.path.join(WebKitFinder(self._port_obj.host.filesystem).path_from_webkit_base('WebDriverTests'), 'imported', 'w3c')

We usually use self._port_obj.host.filesystem.join.

> Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:54
> +            self._port_obj.host.filesystem.remove(temporary_config_file)

Would it be possible to not override the base method here?
Maybe by updating a bit the base method?

> Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:73
>              time.sleep(sleep_secs)

Maybe this could be the default implementation of __wait_for_server?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180417/d5ac0ff1/attachment-0001.html>

More information about the webkit-unassigned mailing list