[Webkit-unassigned] [Bug 184711] New: [GTK][WPE] Build failure due to presence of Avahi's <dns_sd.h> header

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=184711

            Bug ID: 184711
           Summary: [GTK][WPE] Build failure due to presence of Avahi's
                    <dns_sd.h> header
           Product: WebKit
           Version: Other
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebRTC
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: aperez at igalia.com
                CC: youennf at gmail.com

The build failure is:

   […]/NetworkMDNSRegister.cpp:106:53: error: use of undeclared identifier 'dispatch_get_main_queue'
           error = DNSServiceSetDispatchQueue(service, dispatch_get_main_queue());
                                                       ^

Indeed, on GNU/Linux systems we do not have libdispatch! After a
bit of investigation, I have found the following snippet inside
“Source/WebKit/webrtc/NetworkProcess/NetworkMDNSRegister.h”:

  #if defined __has_include && __has_include(<dns_sd.h>)
  #define ENABLE_MDNS 1
  #else
  #define ENABLE_MDNS 0
  #endif

It turns our that in systems with Avahi installed, it may optionally
supply a <dns_sd.h> header which provides a certain degree of compatibility
with Apple's libdns_sd but it is lacks functionality needed by WebKit
(see https://github.com/lathiat/avahi/tree/master/avahi-compat-libdns_sd).

We should detect when Avahi's version is installed, and if that is the
case set ENABLE_MDNS to 0.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180417/4bec0641/attachment.html>