[Webkit-unassigned] [Bug 184619] AX: AOM: respect the accessibility setting for dispatching the accessible events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=184619

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #338060|review+                     |review-
              Flags|                            |

--- Comment #24 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 338060
  --> https://bugs.webkit.org/attachment.cgi?id=338060
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338060&action=review

> Source/WebCore/accessibility/AccessibilityObject.cpp:2160
> -    return RuntimeEnabledFeatures::sharedFeatures().accessibilityObjectModelEnabled();
> +    return RuntimeEnabledFeatures::sharedFeatures().accessibilityObjectModelEnabled() && this->page()->accessibilityEventsEnabled();

accessibilityEventsEnabled should either be a setting on a page or another runtime enabled features.
r- because adding one-off feature flag like this has proven records of accidentally shipping or disabling the feature in a wrong platform.

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:3072
> +    _page->updateAccessibilityEventsEnabled();

Why can't this pass in the boolean to updateAccessibilityEventsEnabled instead of including AccessibilitySupport.h once again in WebPage.cpp?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180417/3ecf7115/attachment.html>