[Webkit-unassigned] [Bug 184674] Commit order should always be returned by api.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 17 02:44:14 PDT 2018
https://bugs.webkit.org/show_bug.cgi?id=184674
Ryosuke Niwa <rniwa at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #338061|review? |review+
Flags| |
--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 338061
--> https://bugs.webkit.org/attachment.cgi?id=338061
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=338061&action=review
> Websites/perf.webkit.org/public/api/measurement-set.php:223
> + $order = !strlen($trimmed_order) ? NULL : intval($trimmed_order);
I think it's a little more straight forward to do: strlen($trimmed_order) ? intval($trimmed_order) : NULL.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180417/369250d2/attachment-0001.html>
More information about the webkit-unassigned
mailing list