[Webkit-unassigned] [Bug 184619] AX: AOM: respect the accessibility setting for dispatching the accessible events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=184619

--- Comment #19 from Nan Wang <n_wang at apple.com> ---
Comment on attachment 338052
  --> https://bugs.webkit.org/attachment.cgi?id=338052
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338052&action=review

>> Source/WTF/wtf/Platform.h:1332
>> +#if (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 120000) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400)
> 
> Should this be cocoa &&( iosversion || macOS version)

I don't think so. By searching through the project, it seems like all the iosversion/macOSversion need to be with PLATFORM(iOS)/PLATFORM(MAC)

>> Source/WebKit/Configurations/WebKit.xcconfig:-42
>> -WK_ACCESSIBILITY_LDFLAGS = $(WK_ACCESSIBILITY_LDFLAGS_$(WK_COCOA_TOUCH));
> 
> Do you still need this change? All platforms should have this

I think so. I just realized that we need to limit the libAccessibility to be linked after 10.14

>> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:210
>> +#if __has_include(<AccessibilitySupport.h>)
> 
> Should this be has_axevents instead of cocoa

Yes!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180417/6b6e410f/attachment.html>