[Webkit-unassigned] [Bug 184650] [GStreamer] Start implementing Audio/VideoTrackPrivateGSTreamer::kind method

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 16 08:45:16 PDT 2018


--- Comment #3 from Philippe Normand <pnormand at igalia.com> ---
Comment on attachment 338000
  --> https://bugs.webkit.org/attachment.cgi?id=338000
[GStreamer] Start implementing Audio/VideoTrackPrivateGSTreamer::kind method

View in context: https://bugs.webkit.org/attachment.cgi?id=338000&action=review

> Source/WebCore/ChangeLog:12
> +        No new tests are added as we already have a few ones that are currently disabled in
> +        the mediastream testsuite. This patch is part of the work to enable them.

Maybe the media/ test suite has a test for this though?

> Source/WebCore/platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp:57
> +    if (m_stream.get() && gst_stream_get_stream_flags (m_stream.get()) & GST_STREAM_FLAG_SELECT)

No space before ( please :)

> Source/WebCore/platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp:57
> +    if (m_stream.get() && gst_stream_get_stream_flags (m_stream.get()) & GST_STREAM_FLAG_SELECT)


You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180416/b9142af7/attachment.html>

More information about the webkit-unassigned mailing list